From: Florian Müllner <fmuellner@gnome.org>
Date: Sat, 22 Feb 2020 13:25:37 +0000 (+0100)
Subject: util: Don't wiggle when animations are disabled
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~772^2^2~62
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=475919720058ee9de45b5f68bb1ee062f7f35563;p=gnome-shell.git

util: Don't wiggle when animations are disabled

repeatCount and autoReverse don't play well with animations disabled:
They cause password entries to wiggle themselves off-screen (by ending
up with some off-scale translation-x value).

While we should handle this more gracefully in the transition helpers,
it also makes sense to handle the case directly in wiggle(): As it
uses a chain of three transitions, we would still end up with a crude
one-frame-per-transition wiggle "animation".

Instead, do no animation at all as you would expect when animations are
disabled.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2236
---

diff --git a/js/misc/util.js b/js/misc/util.js
index 9d30b3f95..c68604e87 100644
--- a/js/misc/util.js
+++ b/js/misc/util.js
@@ -445,6 +445,9 @@ function ensureActorVisibleInScrollView(scrollView, actor) {
 }
 
 function wiggle(actor, params) {
+    if (!St.Settings.get().enable_animations)
+        return;
+
     params = Params.parse(params, {
         offset: WIGGLE_OFFSET,
         duration: WIGGLE_DURATION,